From 640c0f3849ca041b047fd02defea78aa29092812 Mon Sep 17 00:00:00 2001 From: mischief Date: Mon, 15 Dec 2014 12:55:00 -0800 Subject: [PATCH] runtime: fix brk_ signature for plan9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit with uintptr, the check for < 0 will never succeed in mem_plan9.go's sbrk() because the brk_ syscall returns -1 on failure. fixes the plan9/amd64 build. this failed on plan9/amd64 because of the attempt to allocate 136GB in mallocinit(), which failed. it was just by chance that on plan9/386 allocations never failed. Change-Id: Ia3059cf5eb752e20d9e60c9619e591b80e8fb03c Reviewed-on: https://go-review.googlesource.com/1590 Reviewed-by: Anthony Martin Reviewed-by: David du Colombier <0intro@gmail.com> Reviewed-by: Aram Hăvărneanu --- src/runtime/os_plan9.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/runtime/os_plan9.go b/src/runtime/os_plan9.go index 2dcdfc009ab..5a038db497b 100644 --- a/src/runtime/os_plan9.go +++ b/src/runtime/os_plan9.go @@ -18,7 +18,7 @@ func seek(fd int32, offset int64, whence int32) int64 func exits(msg *byte) //go:noescape -func brk_(addr unsafe.Pointer) uintptr +func brk_(addr unsafe.Pointer) int32 func sleep(ms int32) int32