qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 05:20:11 -07:00
Code Releases Activity

runtime: fix brk_ signature for plan9

Browse Source 
with uintptr, the check for < 0 will never succeed in mem_plan9.go's
sbrk() because the brk_ syscall returns -1 on failure. fixes the plan9/amd64 build.

this failed on plan9/amd64 because of the attempt to allocate 136GB in mallocinit(),
which failed. it was just by chance that on plan9/386 allocations never failed.

Change-Id: Ia3059cf5eb752e20d9e60c9619e591b80e8fb03c
Reviewed-on: https://go-review.googlesource.com/1590
Reviewed-by: Anthony Martin <ality@pbrane.org>
Reviewed-by: David du Colombier <0intro@gmail.com>
Reviewed-by: Aram Hăvărneanu <aram@mgk.ro>
This commit is contained in:
mischief 2014-12-15 12:55:00 -08:00 committed by David du Colombier
parent 64e6fe2d29
commit 640c0f3849
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/runtime/os_plan9.go
View File

@ -18,7 +18,7 @@ func seek(fd int32, offset int64, whence int32) int64
func exits(msg *byte)
//go:noescape
func brk_(addr unsafe.Pointer) uintptr
func brk_(addr unsafe.Pointer) int32
func sleep(ms int32) int32