qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 18:44:42 -07:00
Code Releases Activity

internal/lsp: fix lsp trace log format for gopls

Browse Source 
The -rpc.trace flag in gopls enables logging in "lsp inspector format".
Currently sent responses isn't parsed by the lsp inspector so it fails to
parse gopls logs.

The lsp inspector regexp matcher requires the duration to be prefixed with
"took" instead of "in", e.g. "took <d>ms.".

This change updates gopls to match the log parser in lsp inspector,
see 9aff7a6939/lsp-inspector/src/logParser/rawLogParser.ts (L88)

Change-Id: I3696faf34ba4f0b3d4e205693eaf378941f2f68f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/199517
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Pontus Leitzler 2019-10-06 22:41:29 +02:00 committed by Rebecca Stambler
parent 9c6d90b5a7
commit 6223712555
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/lsp/protocol/log.go
View File

@ -211,7 +211,7 @@ func logIn(outfd io.Writer, data []byte) {
} else if v.ID != nil && v.Method == "" && v.Params == nil { } else if v.ID != nil && v.Method == "" && v.Params == nil {
sc := maps.server(id, true) sc := maps.server(id, true)
elapsed := tm.Sub(sc.start) elapsed := tm.Sub(sc.start)
fmt.Fprintf(&buf, "Sending response '%s - (%s)' in %dms.\n", fmt.Fprintf(&buf, "Sending response '%s - (%s)' took %dms.\n",
sc.method, id, elapsed/time.Millisecond) sc.method, id, elapsed/time.Millisecond)
if v.Result == nil { if v.Result == nil {
fmt.Fprintf(&buf, "Result: {}%s", eor) fmt.Fprintf(&buf, "Result: {}%s", eor)