qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 15:46:54 -07:00
Code Releases Activity

runtime: replace unions with structs

Browse Source 
Unions can break precise GC.
Update #5193.

R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/8456043
This commit is contained in:
Dmitriy Vyukov 2013-04-06 20:02:49 -07:00
parent cfe336770b
commit 60682c4f59
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pkg/runtime/atomic_arm.c
View File

@ -5,9 +5,9 @@
#include "runtime.h" #include "runtime.h"
#include "arch_GOARCH.h" #include "arch_GOARCH.h"
static union { static struct {
Lock l; Lock l;
byte pad [CacheLineSize]; byte pad[CacheLineSize-sizeof(Lock)];
} locktab[57]; } locktab[57];
#define LOCK(addr) (&locktab[((uintptr)(addr)>>3)%nelem(locktab)].l) #define LOCK(addr) (&locktab[((uintptr)(addr)>>3)%nelem(locktab)].l)

6
src/pkg/runtime/sema.goc
View File

@ -44,13 +44,13 @@ struct SemaRoot
// Prime to not correlate with any user patterns. // Prime to not correlate with any user patterns.
#define SEMTABLESZ 251 #define SEMTABLESZ 251
union semtable struct semtable
{ {
SemaRoot; SemaRoot;
uint8 pad[CacheLineSize]; uint8 pad[CacheLineSize-sizeof(SemaRoot)];
}; };
#pragma dataflag 16 /* mark semtable as 'no pointers', hiding from garbage collector */ #pragma dataflag 16 /* mark semtable as 'no pointers', hiding from garbage collector */
static union semtable semtable[SEMTABLESZ]; static struct semtable semtable[SEMTABLESZ];
static SemaRoot* static SemaRoot*
semroot(uint32 *addr) semroot(uint32 *addr)