mirror of
https://github.com/golang/go
synced 2024-09-30 08:28:34 -06:00
runtime: disable TestSegv panic check on darwin, illumos, solaris
CL 339990 made this test more strict, exposing pre-existing issues on these OSes. Skip for now until they can be resolved. Updates #49182 Change-Id: I3ac400dcd21b801bf4ab4eeb630e23b5c66ba563 Reviewed-on: https://go-review.googlesource.com/c/go/+/359254 Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan C. Mills <bcmills@google.com> TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
parent
6f0185bf38
commit
5fce1d9613
@ -625,10 +625,18 @@ func TestSegv(t *testing.T) {
|
||||
if !strings.Contains(got, want) {
|
||||
t.Errorf("did not see %q in output", want)
|
||||
}
|
||||
|
||||
// No runtime errors like "runtime: unknown pc".
|
||||
nowant := "runtime: "
|
||||
if strings.Contains(got, nowant) {
|
||||
t.Errorf("unexpectedly saw %q in output", want)
|
||||
switch runtime.GOOS {
|
||||
case "darwin", "illumos", "solaris":
|
||||
// TODO(golang.org/issue/49182): Skip, runtime
|
||||
// throws while attempting to generate
|
||||
// traceback.
|
||||
default:
|
||||
nowant := "runtime: "
|
||||
if strings.Contains(got, nowant) {
|
||||
t.Errorf("unexpectedly saw %q in output", nowant)
|
||||
}
|
||||
}
|
||||
})
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user