qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 08:38:40 -06:00
Code Releases Activity

runtime: disable TestSegv panic check on darwin, illumos, solaris

Browse Source 
CL 339990 made this test more strict, exposing pre-existing issues on
these OSes. Skip for now until they can be resolved.

Updates #49182

Change-Id: I3ac400dcd21b801bf4ab4eeb630e23b5c66ba563
Reviewed-on: https://go-review.googlesource.com/c/go/+/359254
Trust: Michael Pratt <mpratt@google.com>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
This commit is contained in:
Michael Pratt 2021-10-27 16:07:40 -04:00
parent 6f0185bf38
commit 5fce1d9613
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/runtime/crash_cgo_test.go
View File

@ -625,10 +625,18 @@ func TestSegv(t *testing.T) {
if !strings.Contains(got, want) {
t.Errorf("did not see %q in output", want)
}
// No runtime errors like "runtime: unknown pc".
switch runtime.GOOS {
case "darwin", "illumos", "solaris":
// TODO(golang.org/issue/49182): Skip, runtime
// throws while attempting to generate
// traceback.
default:
nowant := "runtime: "
if strings.Contains(got, nowant) {
t.Errorf("unexpectedly saw %q in output", want)
t.Errorf("unexpectedly saw %q in output", nowant)
}
}
})
}