From 5e74bc1a08f43dc98780d02785cfc9c75103c403 Mon Sep 17 00:00:00 2001 From: qmuntal Date: Fri, 3 Mar 2023 16:04:56 +0100 Subject: [PATCH] runtime: skip TestGdbPanic on Windows TestGdbPanic expects crash() to raise a SIGABRT signal interceptable by gdb, but Windows doesn't have signals. Windows builders haven't caught this failing test because they still don't have gdb installed (tracked in #22021). Change-Id: I7c7f2523a54d61aea0a9821c4db7c79e58a7217c Reviewed-on: https://go-review.googlesource.com/c/go/+/473116 Reviewed-by: Dmitri Shuralyov Run-TryBot: Quim Muntal Reviewed-by: Bryan Mills TryBot-Result: Gopher Robot Auto-Submit: Quim Muntal --- src/runtime/runtime-gdb_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 5af3b7455e..1577d0995d 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -661,6 +661,10 @@ func TestGdbPanic(t *testing.T) { t.Parallel() checkGdbVersion(t) + if runtime.GOOS == "windows" { + t.Skip("no signals on windows") + } + dir := t.TempDir() // Build the source code.