From 5e15497b5682acfe5c761bc116c6f157efcc8042 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 18 Apr 2017 10:54:10 -0700 Subject: [PATCH] encoding/hex: change lookup table back to string CL 27254 changed hextable to a byte array for performance. CL 28219 fixed the compiler so that that is no longer necessary. As Kirill notes in #15808, a string is preferable as the linker can easily de-dup it. So go back. No performance changes. Change-Id: Ibef7d21d0f2507968a0606602c5dd57ed4a85b1b Reviewed-on: https://go-review.googlesource.com/40970 Run-TryBot: Josh Bleecher Snyder Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/encoding/hex/hex.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/encoding/hex/hex.go b/src/encoding/hex/hex.go index b43c1c4b456..2768f1bac69 100644 --- a/src/encoding/hex/hex.go +++ b/src/encoding/hex/hex.go @@ -12,10 +12,7 @@ import ( "io" ) -var hextable = [16]byte{ - '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', - 'a', 'b', 'c', 'd', 'e', 'f', -} +const hextable = "0123456789abcdef" // EncodedLen returns the length of an encoding of n source bytes. // Specifically, it returns n * 2.