qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 04:44:39 -07:00
Code Releases Activity

gc: omit argument names from function types in error messages

Browse Source 
Fixes #2563

R=rsc
CC=golang-dev
https://golang.org/cl/5495047
This commit is contained in:
Luuk van Dijk 2011-12-15 17:38:47 +01:00
parent 9bf3478658
commit 5b2f8d96ce
2 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/gc/fmt.c
View File

@ -680,7 +680,7 @@ typefmt(Fmt *fp, Type *t)
case TSTRUCT: case TSTRUCT:
if(t->funarg) { if(t->funarg) {
fmtstrcpy(fp, "("); fmtstrcpy(fp, "(");
if(fmtmode == FTypeId) { // no argument names on function signature, and no "noescape" tags if(fmtmode == FTypeId || fmtmode == FErr) { // no argument names on function signature, and no "noescape" tags
for(t1=t->type; t1!=T; t1=t1->down) for(t1=t->type; t1!=T; t1=t1->down)
if(t1->down) if(t1->down)
fmtprint(fp, "%hT, ", t1); fmtprint(fp, "%hT, ", t1);

12
test/fixedbugs/bug389.go Normal file
View File

@ -0,0 +1,12 @@
// errchk $G $D/$F.go
// Copyright 2011 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 2563
package foo
func fn(a float32) {}
var f func(arg int) = fn // ERROR "cannot use fn .type func.float32.. as type func.int. in assignment"