qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-13 12:40:26 -07:00
Code Releases Activity

cmd/compile/internal/typecheck: remove getcallerpc/sp builtin signature

Browse Source 
The compiler never does a lookup of these (LookupRuntime), so they
aren't needed here.

getcallerpc is only used in intrinsification. getcallersp is used in
intrinsification and defer handling via a direct OGETCALLERSP op.

For #54766.

Change-Id: I1666ceef3360a84573ae5b41b1c51d9205de7235
Reviewed-on: https://go-review.googlesource.com/c/go/+/613495
Reviewed-by: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
Michael Pratt 2024-09-16 13:04:54 -04:00
parent 5367d696f7
commit 5b2f71a2c3
3 changed files with 33 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/compile/internal/typecheck/_builtin/runtime.go
View File

@ -249,9 +249,6 @@ func uint32tofloat64(uint32) float64
func complex128div(num complex128, den complex128) (quo complex128) func complex128div(num complex128, den complex128) (quo complex128)
func getcallerpc() uintptr
func getcallersp() uintptr
// race detection // race detection
func racefuncenter(uintptr) func racefuncenter(uintptr)
func racefuncexit() func racefuncexit()

69
src/cmd/compile/internal/typecheck/builtin.go
View File

@ -207,32 +207,30 @@ var runtimeDecls = [...]struct {
{"uint64tofloat32", funcTag, 145}, {"uint64tofloat32", funcTag, 145},
{"uint32tofloat64", funcTag, 146}, {"uint32tofloat64", funcTag, 146},
{"complex128div", funcTag, 147}, {"complex128div", funcTag, 147},
{"getcallerpc", funcTag, 148},
{"getcallersp", funcTag, 148},
{"racefuncenter", funcTag, 31}, {"racefuncenter", funcTag, 31},
{"racefuncexit", funcTag, 9}, {"racefuncexit", funcTag, 9},
{"raceread", funcTag, 31}, {"raceread", funcTag, 31},
{"racewrite", funcTag, 31}, {"racewrite", funcTag, 31},
{"racereadrange", funcTag, 149}, {"racereadrange", funcTag, 148},
{"racewriterange", funcTag, 149}, {"racewriterange", funcTag, 148},
{"msanread", funcTag, 149}, {"msanread", funcTag, 148},
{"msanwrite", funcTag, 149}, {"msanwrite", funcTag, 148},
{"msanmove", funcTag, 150}, {"msanmove", funcTag, 149},
{"asanread", funcTag, 149}, {"asanread", funcTag, 148},
{"asanwrite", funcTag, 149}, {"asanwrite", funcTag, 148},
{"checkptrAlignment", funcTag, 151}, {"checkptrAlignment", funcTag, 150},
{"checkptrArithmetic", funcTag, 153}, {"checkptrArithmetic", funcTag, 152},
{"libfuzzerTraceCmp1", funcTag, 154}, {"libfuzzerTraceCmp1", funcTag, 153},
{"libfuzzerTraceCmp2", funcTag, 155}, {"libfuzzerTraceCmp2", funcTag, 154},
{"libfuzzerTraceCmp4", funcTag, 156}, {"libfuzzerTraceCmp4", funcTag, 155},
{"libfuzzerTraceCmp8", funcTag, 157}, {"libfuzzerTraceCmp8", funcTag, 156},
{"libfuzzerTraceConstCmp1", funcTag, 154}, {"libfuzzerTraceConstCmp1", funcTag, 153},
{"libfuzzerTraceConstCmp2", funcTag, 155}, {"libfuzzerTraceConstCmp2", funcTag, 154},
{"libfuzzerTraceConstCmp4", funcTag, 156}, {"libfuzzerTraceConstCmp4", funcTag, 155},
{"libfuzzerTraceConstCmp8", funcTag, 157}, {"libfuzzerTraceConstCmp8", funcTag, 156},
{"libfuzzerHookStrCmp", funcTag, 158}, {"libfuzzerHookStrCmp", funcTag, 157},
{"libfuzzerHookEqualFold", funcTag, 158}, {"libfuzzerHookEqualFold", funcTag, 157},
{"addCovMeta", funcTag, 160}, {"addCovMeta", funcTag, 159},
{"x86HasPOPCNT", varTag, 6}, {"x86HasPOPCNT", varTag, 6},
{"x86HasSSE41", varTag, 6}, {"x86HasSSE41", varTag, 6},
{"x86HasFMA", varTag, 6}, {"x86HasFMA", varTag, 6},
@ -242,7 +240,7 @@ var runtimeDecls = [...]struct {
} }
func runtimeTypes() []*types.Type { func runtimeTypes() []*types.Type {
var typs [161]*types.Type var typs [160]*types.Type
typs[0] = types.ByteType typs[0] = types.ByteType
typs[1] = types.NewPtr(typs[0]) typs[1] = types.NewPtr(typs[0])
typs[2] = types.Types[types.TANY] typs[2] = types.Types[types.TANY]
@ -391,19 +389,18 @@ func runtimeTypes() []*types.Type {
typs[145] = newSig(params(typs[24]), params(typs[142])) typs[145] = newSig(params(typs[24]), params(typs[142]))
typs[146] = newSig(params(typs[65]), params(typs[20])) typs[146] = newSig(params(typs[65]), params(typs[20]))
typs[147] = newSig(params(typs[26], typs[26]), params(typs[26])) typs[147] = newSig(params(typs[26], typs[26]), params(typs[26]))
typs[148] = newSig(nil, params(typs[5])) typs[148] = newSig(params(typs[5], typs[5]), nil)
typs[149] = newSig(params(typs[5], typs[5]), nil) typs[149] = newSig(params(typs[5], typs[5], typs[5]), nil)
typs[150] = newSig(params(typs[5], typs[5], typs[5]), nil) typs[150] = newSig(params(typs[7], typs[1], typs[5]), nil)
typs[151] = newSig(params(typs[7], typs[1], typs[5]), nil) typs[151] = types.NewSlice(typs[7])
typs[152] = types.NewSlice(typs[7]) typs[152] = newSig(params(typs[7], typs[151]), nil)
typs[153] = newSig(params(typs[7], typs[152]), nil) typs[153] = newSig(params(typs[69], typs[69], typs[17]), nil)
typs[154] = newSig(params(typs[69], typs[69], typs[17]), nil) typs[154] = newSig(params(typs[63], typs[63], typs[17]), nil)
typs[155] = newSig(params(typs[63], typs[63], typs[17]), nil) typs[155] = newSig(params(typs[65], typs[65], typs[17]), nil)
typs[156] = newSig(params(typs[65], typs[65], typs[17]), nil) typs[156] = newSig(params(typs[24], typs[24], typs[17]), nil)
typs[157] = newSig(params(typs[24], typs[24], typs[17]), nil) typs[157] = newSig(params(typs[28], typs[28], typs[17]), nil)
typs[158] = newSig(params(typs[28], typs[28], typs[17]), nil) typs[158] = types.NewArray(typs[0], 16)
typs[159] = types.NewArray(typs[0], 16) typs[159] = newSig(params(typs[7], typs[65], typs[158], typs[28], typs[15], typs[69], typs[69]), params(typs[65]))
typs[160] = newSig(params(typs[7], typs[65], typs[159], typs[28], typs[15], typs[69], typs[69]), params(typs[65]))
return typs[:] return typs[:]
} }

2
src/cmd/internal/goobj/builtinlist.go
View File

@ -186,8 +186,6 @@ var builtins = [...]struct {
{"runtime.uint64tofloat32", 1}, {"runtime.uint64tofloat32", 1},
{"runtime.uint32tofloat64", 1}, {"runtime.uint32tofloat64", 1},
{"runtime.complex128div", 1}, {"runtime.complex128div", 1},
{"runtime.getcallerpc", 1},
{"runtime.getcallersp", 1},
{"runtime.racefuncenter", 1}, {"runtime.racefuncenter", 1},
{"runtime.racefuncexit", 1}, {"runtime.racefuncexit", 1},
{"runtime.raceread", 1}, {"runtime.raceread", 1},