qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 14:07:56 -07:00
Code Releases Activity

codereview: fix windows

Browse Source 
Uploading go files on Windows aborts with gofmt: exceptions.ValueError:
close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr

R=rsc, mattn, Joe Poirier
CC=golang-dev
https://golang.org/cl/4025046
This commit is contained in:
Hector Chu 2011-01-24 14:16:24 -05:00 committed by Russ Cox
parent 17fc373af7
commit 59a6395279
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/codereview/codereview.py
View File

@ -911,7 +911,7 @@ def CheckGofmt(ui, repo, files, just_warn):
if not files: if not files:
return return
try: try:
cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=True) cmd = subprocess.Popen(["gofmt", "-l"] + files, shell=False, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE, close_fds=sys.platform != "win32")
cmd.stdin.close() cmd.stdin.close()
except: except:
raise util.Abort("gofmt: " + ExceptionDetail()) raise util.Abort("gofmt: " + ExceptionDetail())