qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 15:04:44 -07:00
Code Releases Activity

internal/lsp: include context in go/packages config

Browse Source 
Include the context when invoking go/packages.Load so it is
cancelable. Otherwise if the user is manually typing an import or
otherwise messing around with imports, a big queue of potentially very
slow go/packages.Load calls will build up.

Fixes golang/go#34414.

Change-Id: I80732086b478b908c720739708dd773e81fe2b81
Reviewed-on: https://go-review.googlesource.com/c/tools/+/200058
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
This commit is contained in:
Muir Manders 2019-10-09 11:11:22 -07:00 committed by Rebecca Stambler
parent 638914d249
commit 59731289e9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
internal/lsp/cache/view.go vendored
View File

@ -109,6 +109,7 @@ func (v *view) Config(ctx context.Context) *packages.Config {
// TODO: Should we cache the config and/or overlay somewhere? // TODO: Should we cache the config and/or overlay somewhere?
return &packages.Config{ return &packages.Config{
Dir: v.folder.Filename(), Dir: v.folder.Filename(),
Context: ctx,
Env: v.options.Env, Env: v.options.Env,
BuildFlags: v.options.BuildFlags, BuildFlags: v.options.BuildFlags,
Mode: packages.NeedName | Mode: packages.NeedName |