qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 11:44:45 -07:00
Code Releases Activity

cover: accept inaccurate block endings

Browse Source 
When cover is used with cgo packages, the coverage profile is produced
from the cgo-generated Go source files, so the profile will reference
line and column numbers from that generated source, even though it names
the original file.
This is okay in general because the cgo-generated Go source files are
very similar to the original, with one significant exception:
the original source may refer to C identifiers such as C.foo(), but the
cgo tool generates source that rewrites these mentions to something like
_Cfunc_foo.
This means that column numbers in coverage profiles might be higher than
they should be, so be lenient when interpreting them.

Update golang/go#9479

Change-Id: Ic3abef07471614101ce0c686d35b85e7e5e6a777
Reviewed-on: https://go-review.googlesource.com/2410
Reviewed-by: Rob Pike <r@golang.org>
This commit is contained in:
Andrew Gerrand 2015-01-07 12:46:00 +11:00
parent c836fe615a
commit 57335a8a8f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cover/profile.go
View File

@ -162,7 +162,7 @@ func (p *Profile) Boundaries(src []byte) (boundaries []Boundary) {
if b.StartLine == line && b.StartCol == col { if b.StartLine == line && b.StartCol == col {
boundaries = append(boundaries, boundary(si, true, b.Count)) boundaries = append(boundaries, boundary(si, true, b.Count))
} }
if b.EndLine == line && b.EndCol == col { if b.EndLine == line && b.EndCol == col || line > b.EndLine {
boundaries = append(boundaries, boundary(si, false, 0)) boundaries = append(boundaries, boundary(si, false, 0))
bi++ bi++
continue // Don't advance through src; maybe the next block starts here. continue // Don't advance through src; maybe the next block starts here.