From 56cd47b295e033f39534d80effc45f4abe125bec Mon Sep 17 00:00:00 2001 From: Russ Cox Date: Fri, 12 Jul 2013 07:34:16 -0400 Subject: [PATCH] cmd/go, testing: remove redundant "for pkg" in coverage message This is a transcript before this change. I've capitalized the text being removed. Note that it is always near another line that already says fmt, marked with <<< $ cd $GOROOT/src/pkg/fmt $ go test -cover PASS coverage FOR FMT: 91.3% of statements ok fmt 0.040s <<< $ go test -coverpkg strconv PASS coverage FOR FMT: 64.9% of statements in strconv ok fmt 0.039s <<< $ go test -cover -c $ ./fmt.test -test.covermode=set <<< PASS coverage FOR FMT: 91.3% of statements $ go test -coverpkg strconv -c $ ./fmt.test -test.covermode=set <<< PASS coverage FOR FMT: 64.9% of statements in strconv That the summary printed by 'go test [options] fmt' is unchanged: $ go test -cover fmt ok fmt 0.040s coverage: 91.3% of statements $ go test -coverpkg strconv fmt ok fmt 0.038s coverage: 64.9% of statements in strconv R=r CC=gobot, golang-dev https://golang.org/cl/10932045 --- src/cmd/go/test.go | 2 +- src/pkg/testing/cover.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/test.go b/src/cmd/go/test.go index 57b764586a7..50de8f292cc 100644 --- a/src/cmd/go/test.go +++ b/src/cmd/go/test.go @@ -937,7 +937,7 @@ func coveragePercentage(out []byte) string { // The string looks like // test coverage for encoding/binary: 79.9% of statements // Extract the piece from the percentage to the end of the line. - re := regexp.MustCompile(`coverage for [^ ]+: (.*)\n`) + re := regexp.MustCompile(`coverage: (.*)\n`) matches := re.FindSubmatch(out) if matches == nil { // Probably running "go test -cover" not "go test -cover fmt". diff --git a/src/pkg/testing/cover.go b/src/pkg/testing/cover.go index 4f66a0b7920..22a5299b8f5 100644 --- a/src/pkg/testing/cover.go +++ b/src/pkg/testing/cover.go @@ -89,5 +89,5 @@ func coverReport() { if total == 0 { total = 1 } - fmt.Printf("coverage for %s: %.1f%% of statements%s\n", testedPackage, 100*float64(active)/float64(total), coveredPackage) + fmt.Printf("coverage: %.1f%% of statements%s\n", 100*float64(active)/float64(total), coveredPackage) }