qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 02:34:40 -07:00
Code Releases Activity

govet: on error continue to the next file

Browse Source 
R=r, rsc
CC=golang-dev
https://golang.org/cl/3578041
This commit is contained in:
Christopher Wedgwood 2010-12-14 14:12:22 -08:00 committed by Rob Pike
parent 9f6de01d8d
commit 56452c53ee
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/cmd/govet/govet.go
View File

@ -23,6 +23,14 @@ var verbose = flag.Bool("v", false, "verbose")
var printfuncs = flag.String("printfuncs", "", "comma-separated list of print function names to check") var printfuncs = flag.String("printfuncs", "", "comma-separated list of print function names to check")
var exitCode = 0 var exitCode = 0
// setExit sets the value for os.Exit when it is called, later. It
// remembers the highest value.
func setExit(err int) {
if err > exitCode {
exitCode = err
}
}
// Usage is a replacement usage function for the flags package. // Usage is a replacement usage function for the flags package.
func Usage() { func Usage() {
fmt.Fprintf(os.Stderr, "Usage of %s:\n", os.Args[0]) fmt.Fprintf(os.Stderr, "Usage of %s:\n", os.Args[0])
@ -50,7 +58,7 @@ func main() {
var err os.Error var err os.Error
skip, err = strconv.Atoi(name[colon+1:]) skip, err = strconv.Atoi(name[colon+1:])
if err != nil { if err != nil {
die(`illegal format for "Func:N" argument %q; %s`, name, err) error(`illegal format for "Func:N" argument %q; %s`, name, err)
} }
name = name[:colon] name = name[:colon]
} }
@ -79,17 +87,18 @@ func doFile(name string, reader io.Reader) {
fs := token.NewFileSet() fs := token.NewFileSet()
parsedFile, err := parser.ParseFile(fs, name, reader, 0) parsedFile, err := parser.ParseFile(fs, name, reader, 0)
if err != nil { if err != nil {
die("%s: %s", name, err) error("%s: %s", name, err)
return
} }
file := &File{fs.File(parsedFile.Pos())} file := &File{fs.File(parsedFile.Pos())}
file.checkFile(name, parsedFile) file.checkFile(name, parsedFile)
} }
// die formats the error to standard error, adding program identification // error formats the error to standard error, adding program
// and a newline, and exits the program. // identification and a newline
func die(format string, args ...interface{}) { func error(format string, args ...interface{}) {
fmt.Fprintf(os.Stderr, "govet: "+format+"\n", args...) fmt.Fprintf(os.Stderr, "govet: "+format+"\n", args...)
os.Exit(2) setExit(2)
} }
// Println is fmt.Println guarded by -v. // Println is fmt.Println guarded by -v.
@ -111,13 +120,13 @@ func Printf(format string, args ...interface{}) {
// Bad reports an error and sets the exit code.. // Bad reports an error and sets the exit code..
func (f *File) Bad(pos token.Pos, args ...interface{}) { func (f *File) Bad(pos token.Pos, args ...interface{}) {
f.Warn(pos, args...) f.Warn(pos, args...)
exitCode = 1 setExit(1)
} }
// Badf reports a formatted error and sets the exit code. // Badf reports a formatted error and sets the exit code.
func (f *File) Badf(pos token.Pos, format string, args ...interface{}) { func (f *File) Badf(pos token.Pos, format string, args ...interface{}) {
f.Warnf(pos, format, args...) f.Warnf(pos, format, args...)
exitCode = 1 setExit(1)
} }
// Warn reports an error but does not set the exit code. // Warn reports an error but does not set the exit code.