qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 19:54:44 -07:00
Code Releases Activity

net/http: remove TestTimeoutHandlerAndFlusher due to flakes

Browse Source 
Removes TestTimeoutHandlerAndFlusher due to flakes on
one of the builders due to timing issues.

Perhaps later, we might need to bring it back when we've
figured out the timing issues.

Fixes #34573.

Change-Id: Ia88d4da31fb228296144dc31f9a4288167fb4a53
Reviewed-on: https://go-review.googlesource.com/c/go/+/197757
Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Emmanuel T Odeke 2019-09-27 08:21:27 -07:00 committed by Emmanuel Odeke
parent 70a1efbb5c
commit 55738850c4
1 changed files with 0 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
src/net/http/serve_test.go
View File

@ -6161,54 +6161,6 @@ func TestUnsupportedTransferEncodingsReturn501(t *testing.T) {
}
}
// Issue 34439: ensure that TimeoutHandler doesn't implement Flusher
// and that any interaction with Flusher won't affect TimeoutHandler's behavior.
func TestTimeoutHandlerAndFlusher(t *testing.T) {
timeout := 50 * time.Millisecond
handler := HandlerFunc(func(w ResponseWriter, r *Request) {
w.WriteHeader(StatusTeapot)
w.Write([]byte("line1\n"))
fl, ok := w.(Flusher)
if ok {
fl.Flush()
}
time.Sleep(timeout * 2)
w.Write([]byte("line2\n"))
})
cst := httptest.NewUnstartedServer(TimeoutHandler(handler, timeout, "TIMED OUT\n"))
// Provide a logger that will report an error on any superfluous log.
cst.Config.ErrorLog = log.New(&errorOnWrite{t: t}, "", 0)
cst.Start()
defer cst.Close()
res, err := cst.Client().Get(cst.URL)
if err != nil {
t.Fatal(err)
}
defer res.Body.Close()
if g, w := res.StatusCode, StatusServiceUnavailable; g != w {
t.Errorf("Status code mismatch\ngot: %d\nwant: %d", g, w)
}
slurp, _ := ioutil.ReadAll(res.Body)
if g, w := string(slurp), "TIMED OUT\n"; g != w {
t.Fatalf("Body mismatch\ngot: %q\nwant: %q", g, w)
}
}
// errorOnWrite will invoke t.Error on any attempted write.
type errorOnWrite struct {
t *testing.T
}
func (ew *errorOnWrite) Write(b []byte) (int, error) {
ew.t.Errorf("Unexpected write: %s\n", b)
return len(b), nil
}
// fetchWireResponse is a helper for dialing to host,
// sending http1ReqBody as the payload and retrieving
// the response as it was sent on the wire.