From 55567d37e9c0543347239df69888f5f321fc9d08 Mon Sep 17 00:00:00 2001 From: Rob Pike Date: Wed, 16 Mar 2016 13:28:32 +1100 Subject: [PATCH] path: fix up bizarre test The Join test was doing something remarkable and unnecessary instead of just using ... on a slice. Maybe it was an editing relic. Fix it by deleting the monstrosity. Change-Id: I5b90c6d539d334a9c27e57d26dacd831721cfcfe Reviewed-on: https://go-review.googlesource.com/20727 Reviewed-by: Brad Fitzpatrick Run-TryBot: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/path/path_test.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/path/path_test.go b/src/path/path_test.go index 13b585223f8..85b2450a620 100644 --- a/src/path/path_test.go +++ b/src/path/path_test.go @@ -135,15 +135,9 @@ var jointests = []JoinTest{ {[]string{"", ""}, ""}, } -// join takes a []string and passes it to Join. -func join(elem []string, args ...string) string { - args = elem - return Join(args...) -} - func TestJoin(t *testing.T) { for _, test := range jointests { - if p := join(test.elem); p != test.path { + if p := Join(test.elem...); p != test.path { t.Errorf("join(%q) = %q, want %q", test.elem, p, test.path) } }