From 55282111585087d35c5af57dc5bdcf9a886debe7 Mon Sep 17 00:00:00 2001 From: Andrew Gerrand Date: Thu, 7 Jun 2012 09:27:39 +1000 Subject: [PATCH] misc/dashboard/app: fix build failure notifications The datastore.Query methods once mutated the Query value, but now they return a derivative query, so the Hash= and ParentHash= filters were not being applied. R=golang-dev, bradfitz, dsymonds CC=golang-dev https://golang.org/cl/6300058 --- misc/dashboard/app/build/notify.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/misc/dashboard/app/build/notify.go b/misc/dashboard/app/build/notify.go index f4c6733598b..afcc7b2db54 100644 --- a/misc/dashboard/app/build/notify.go +++ b/misc/dashboard/app/build/notify.go @@ -45,7 +45,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { if cr.OK { // This commit is OK. Notify if next Commit is broken. next := new(Commit) - q.Filter("ParentHash=", com.Hash) + q = q.Filter("ParentHash=", com.Hash) if err := firstMatch(c, q, next); err != nil { if err == datastore.ErrNoSuchEntity { // OK at tip, no notification necessary. @@ -61,7 +61,7 @@ func notifyOnFailure(c appengine.Context, com *Commit, builder string) error { } else { // This commit is broken. Notify if the previous Commit is OK. prev := new(Commit) - q.Filter("Hash=", com.ParentHash) + q = q.Filter("Hash=", com.ParentHash) if err := firstMatch(c, q, prev); err != nil { if err == datastore.ErrNoSuchEntity { // No previous result, let the backfill of