From 54f0520f940f7edd916c34b7d44f9fc2c9e48cf7 Mon Sep 17 00:00:00 2001 From: Than McIntosh Date: Mon, 18 Dec 2017 13:58:41 -0500 Subject: [PATCH] cmd/internal/link: disable selected DWARF tests on Solaris Disable the three linker DWARF tests that invoke the compiler in non-debug mode on Solaris, since this seems to trigger a split stack overflow. These can be turned back on once the issue in question is resolved. Updates #23168. Change-Id: I5be1b098e33e8bad3bc234a0964eab1dee7e7954 Reviewed-on: https://go-review.googlesource.com/84655 Reviewed-by: Brad Fitzpatrick Run-TryBot: Than McIntosh --- src/cmd/link/internal/ld/dwarf_test.go | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/src/cmd/link/internal/ld/dwarf_test.go b/src/cmd/link/internal/ld/dwarf_test.go index 202ab8fcfc..391601acaf 100644 --- a/src/cmd/link/internal/ld/dwarf_test.go +++ b/src/cmd/link/internal/ld/dwarf_test.go @@ -531,6 +531,9 @@ func TestInlinedRoutineRecords(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } + if runtime.GOOS == "solaris" { + t.Skip("skipping on solaris, pending resolution of issue #23168") + } const prog = ` package main @@ -748,6 +751,9 @@ func TestAbstractOriginSanity(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } + if runtime.GOOS == "solaris" { + t.Skip("skipping on solaris, pending resolution of issue #23168") + } abstractOriginSanity(t, OptInl4) } @@ -758,6 +764,9 @@ func TestAbstractOriginSanityWithLocationLists(t *testing.T) { if runtime.GOOS == "plan9" { t.Skip("skipping on plan9; no DWARF symbol table in executables") } + if runtime.GOOS == "solaris" { + t.Skip("skipping on solaris, pending resolution of issue #23168") + } if runtime.GOARCH != "amd64" && runtime.GOARCH != "x86" { t.Skip("skipping on not-amd64 not-x86; location lists not supported") }