From 545ef1103712dda49542709d48ce030addecb8e7 Mon Sep 17 00:00:00 2001 From: Matthew Dempsky Date: Mon, 23 Apr 2018 10:52:16 -0700 Subject: [PATCH] cmd/compile: remove toolstash workaround in bexport.go Change-Id: Ie4facdcab4b35cf7d350c4b8fa06a3c5a0c6caeb Reviewed-on: https://go-review.googlesource.com/108875 Run-TryBot: Matthew Dempsky Reviewed-by: Brad Fitzpatrick TryBot-Result: Gobot Gobot --- src/cmd/compile/internal/gc/bexport.go | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/cmd/compile/internal/gc/bexport.go b/src/cmd/compile/internal/gc/bexport.go index 6644827635..d71c069cfc 100644 --- a/src/cmd/compile/internal/gc/bexport.go +++ b/src/cmd/compile/internal/gc/bexport.go @@ -1002,13 +1002,7 @@ func parName(f *types.Field, numbered bool) string { return "" } - // The "s != f.Sym" check here is unnecessary and causes blank - // input/receiver parameters to receive vargen numbers - // below. However, this is consistent with the logic it - // replaces, so we keep it for now to appease toolstash-check. - // - // TODO(mdempsky): Simplify to just "if s.Name == "_"". - if s != f.Sym && s.Name == "_" { + if s.Name == "_" { return "_" }