qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-07 11:46:17 -07:00
Code Releases Activity

os: skip TestExecutableDeleted earlier when 'go build' is not supported

Browse Source 
The test unconditionally calls testenv.GoToolPath, which will skip the
test anyway. Moving the skip earlier gets this test out of goroutine
dumps if the test process fails or times out, making it easier to
diagnose failures in the remaining tests.

Change-Id: Ibd39546708a83b6f15616b2c4ae7af420e2401f0
Reviewed-on: https://go-review.googlesource.com/c/go/+/475455
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Bryan C. Mills 2023-03-10 14:21:01 -05:00 committed by Gopher Robot
parent d12fe60004
commit 53c91f9205
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/os/executable_test.go
View File

@ -89,7 +89,7 @@ func init() {
}
func TestExecutableDeleted(t *testing.T) {
testenv.MustHaveExec(t)
testenv.MustHaveGoBuild(t)
switch runtime.GOOS {
case "windows", "plan9":
t.Skipf("%v does not support deleting running binary", runtime.GOOS)