qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 09:50:03 -07:00
Code Releases Activity

runtime: change sigset_all and sigset_none into constants on OpenBSD

Browse Source 
OpenBSD's sigprocmask system call passes the signal mask by value
rather than reference, so vars are unnecessary.  Additionally,
declaring "var sigset_all = ^sigset_none" means sigset_all won't be
initialized until runtime_init is called, but the first call to
newosproc happens before then.

I've witnessed Go processes on OpenBSD crash from receiving SIGWINCH
on the newly created OS thread before it finished initializing.

Change-Id: I16995e7e466d5e7e50bcaa7d9490173789a0b4cc
Reviewed-on: https://go-review.googlesource.com/6440
Reviewed-by: Mikio Hara <mikioh.mikioh@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Matthew Dempsky 2015-03-01 19:13:50 -08:00 committed by Mikio Hara
parent fcc164d783
commit 5324cf2d45
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/runtime/os1_openbsd.go
View File

@ -19,8 +19,10 @@ const (
_CLOCK_MONOTONIC = 3
)
var sigset_none = uint32(0)
var sigset_all = ^sigset_none
const (
sigset_none = uint32(0)
sigset_all = ^uint32(0)
)
// From OpenBSD's <sys/sysctl.h>
const (