qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 04:07:55 -07:00
Code Releases Activity

gc: bug308

Browse Source 
confused by using isddd for both ONAME and OCALL

Fixes #1136.

R=ken2
CC=golang-dev
https://golang.org/cl/2314043
This commit is contained in:
Russ Cox 2010-09-30 15:05:01 -04:00
parent 779dfea487
commit 52d619cfdf
2 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/gc/typecheck.c
View File

@ -1550,7 +1550,7 @@ typecheckaste(int op, int isddd, Type *tstruct, NodeList *nl, char *desc)
for(tl=tstruct->type; tl; tl=tl->down) {
t = tl->type;
if(tl->isddd) {
if(nl != nil && nl->n->isddd && !isddd) {
if(nl != nil && nl->n->op == ONAME && nl->n->isddd && !isddd) {
// TODO(rsc): This is not actually illegal, but it will help catch bugs.
yyerror("to pass '%#N' as ...%T, use '%#N...'", nl->n, t->type, nl->n);
isddd = 1;

19
test/fixedbugs/bug308.go Normal file
View File

@ -0,0 +1,19 @@
// $G $D/$F.go
// Copyright 2010 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// issue 1136
package main
import "fmt"
func log1(f string, argv ...interface{}) {
fmt.Printf("log: %s\n", fmt.Sprintf(f, argv...))
}
func main() {
log1("%d", 42)
}