qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 21:54:49 -07:00
Code Releases Activity

cmd/go: add a debug-trace flag to generate traces

Browse Source 
If cmd/go is provided with a -debug-trace=<file> option, cmd/go will write an
execution trace to that file.

Updates #38714

Change-Id: I3e6521343902c08266a0292f4280298a3bf8b725
Reviewed-on: https://go-review.googlesource.com/c/go/+/237683
Run-TryBot: Michael Matloob <matloob@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
Reviewed-by: Bryan C. Mills <bcmills@google.com>
This commit is contained in:
Michael Matloob 2020-04-14 17:29:27 -04:00
parent 20254c02b3
commit 52b0ea20ff
3 changed files with 26 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cmd/go/internal/cfg/cfg.go
View File

@ -51,6 +51,7 @@ var (
CmdName string // "build", "install", "list", "mod tidy", etc.
DebugActiongraph string // -debug-actiongraph flag (undocumented, unstable)
DebugTrace string // -debug-trace flag
)
func defaultContext() build.Context {

1
src/cmd/go/internal/work/build.go
View File

@ -270,6 +270,7 @@ func AddBuildFlags(cmd *base.Command, mask BuildFlagMask) {
// Undocumented, unstable debugging flags.
cmd.Flag.StringVar(&cfg.DebugActiongraph, "debug-actiongraph", "", "")
cmd.Flag.StringVar(&cfg.DebugTrace, "debug-trace", "", "")
}
// AddModCommonFlags adds the module-related flags common to build commands

24
src/cmd/go/main.go
View File

@ -7,6 +7,7 @@
package main
import (
"context"
"flag"
"fmt"
"log"
@ -34,6 +35,7 @@ import (
"cmd/go/internal/run"
"cmd/go/internal/test"
"cmd/go/internal/tool"
"cmd/go/internal/trace"
"cmd/go/internal/version"
"cmd/go/internal/vet"
"cmd/go/internal/work"
@ -187,7 +189,11 @@ BigCmdLoop:
cmd.Flag.Parse(args[1:])
args = cmd.Flag.Args()
}
ctx := maybeStartTrace(context.Background())
ctx, span := trace.StartSpan(ctx, fmt.Sprint("Running ", cmd.Name(), " command"))
_ = ctx
cmd.Run(cmd, args)
span.Done()
base.Exit()
return
}
@ -209,3 +215,21 @@ func mainUsage() {
help.PrintUsage(os.Stderr, base.Go)
os.Exit(2)
}
func maybeStartTrace(pctx context.Context) context.Context {
if cfg.DebugTrace == "" {
return pctx
}
ctx, close, err := trace.Start(pctx, cfg.DebugTrace)
if err != nil {
base.Fatalf("failed to start trace: %v", err)
}
base.AtExit(func() {
if err := close(); err != nil {
base.Fatalf("failed to stop trace: %v", err)
}
})
return ctx
}