qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 09:24:41 -07:00
Code Releases Activity

os: use t.TempDir in TestMkdirTemp, TestCreateTemp

Browse Source 
This simplifies tests a little bit.

Change-Id: I910e3c97cfd20b26951d2a4909d86b5be06bde56
Reviewed-on: https://go-review.googlesource.com/c/go/+/606899
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
This commit is contained in:
Kir Kolyshkin 2024-08-19 15:46:15 -07:00 committed by Gopher Robot
parent ef0b015407
commit 5187baeb4e
1 changed files with 5 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
src/os/tempfile_test.go
View File

@ -17,13 +17,7 @@ import (
func TestCreateTemp(t *testing.T) {
t.Parallel()
dir, err := MkdirTemp("", "TestCreateTempBadDir")
if err != nil {
t.Fatal(err)
}
defer RemoveAll(dir)
nonexistentDir := filepath.Join(dir, "_not_exists_")
nonexistentDir := filepath.Join(t.TempDir(), "_not_exists_")
f, err := CreateTemp(nonexistentDir, "foo")
if f != nil || err == nil {
t.Errorf("CreateTemp(%q, `foo`) = %v, %v", nonexistentDir, f, err)
@ -57,11 +51,7 @@ func TestCreateTempPattern(t *testing.T) {
func TestCreateTempBadPattern(t *testing.T) {
t.Parallel()
tmpDir, err := MkdirTemp("", t.Name())
if err != nil {
t.Fatal(err)
}
defer RemoveAll(tmpDir)
tmpDir := t.TempDir()
const sep = string(PathSeparator)
tests := []struct {
@ -152,14 +142,8 @@ func TestMkdirTemp(t *testing.T) {
func TestMkdirTempBadDir(t *testing.T) {
t.Parallel()
dir, err := MkdirTemp("", "MkdirTempBadDir")
if err != nil {
t.Fatal(err)
}
defer RemoveAll(dir)
badDir := filepath.Join(dir, "not-exist")
_, err = MkdirTemp(badDir, "foo")
badDir := filepath.Join(t.TempDir(), "not-exist")
_, err := MkdirTemp(badDir, "foo")
if pe, ok := err.(*fs.PathError); !ok || !IsNotExist(err) || pe.Path != badDir {
t.Errorf("TempDir error = %#v; want PathError for path %q satisfying IsNotExist", err, badDir)
}
@ -168,11 +152,7 @@ func TestMkdirTempBadDir(t *testing.T) {
func TestMkdirTempBadPattern(t *testing.T) {
t.Parallel()
tmpDir, err := MkdirTemp("", t.Name())
if err != nil {
t.Fatal(err)
}
defer RemoveAll(tmpDir)
tmpDir := t.TempDir()
const sep = string(PathSeparator)
tests := []struct {