qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 11:10:04 -07:00
Code Releases Activity

cmd/dist: skip static linking tests for linux boringcrypto

Browse Source 
Otherwise we get warnings from the C linker.

Fixes #59422

Change-Id: I61843dbe5245da0185b0f23dc4b774767fffed40
Reviewed-on: https://go-review.googlesource.com/c/go/+/482315
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This commit is contained in:
Ian Lance Taylor 2023-04-04 14:43:46 -07:00 committed by Gopher Robot
parent a8ca653892
commit 508f445a28
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/cmd/dist/test.go vendored
View File

@ -1266,6 +1266,17 @@ func (t *tester) registerCgoTests() {
} }
} }
// Doing a static link with boringcrypto gets
// a C linker warning on Linux.
// in function `bio_ip_and_port_to_socket_and_addr':
// warning: Using 'getaddrinfo' in statically linked applications requires at runtime the shared libraries from the glibc version used for linking
if staticCheck.pre == nil && goos == "linux" && strings.Contains(goexperiment, "boringcrypto") {
staticCheck.pre = func(*distTest) bool {
fmt.Println("skipping static linking check on Linux when using boringcrypto to avoid C linker warning about getaddrinfo")
return false
}
}
// Static linking tests // Static linking tests
if goos != "android" && p != "netbsd/arm" { if goos != "android" && p != "netbsd/arm" {
// TODO(#56629): Why does this fail on netbsd-arm? // TODO(#56629): Why does this fail on netbsd-arm?