From 507d5b1f74b2f2d0a75d61fe169cc0cc40d132c0 Mon Sep 17 00:00:00 2001 From: sivchari Date: Mon, 10 Oct 2022 23:47:45 +0900 Subject: [PATCH] cmd/go/internal/load: improve comments This change modifies test.go isTestFunc checked whether the parameter type is B, M or T before the version of Go1.17. But, after Go1.18, isTestFunc checks F, too. --- src/cmd/go/internal/load/test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/go/internal/load/test.go b/src/cmd/go/internal/load/test.go index e9ed0d332bc..b3090b4f980 100644 --- a/src/cmd/go/internal/load/test.go +++ b/src/cmd/go/internal/load/test.go @@ -560,7 +560,7 @@ func recompileForTest(pmain, preal, ptest, pxtest *Package) *PackageError { } // isTestFunc tells whether fn has the type of a testing function. arg -// specifies the parameter type we look for: B, M or T. +// specifies the parameter type we look for: B, F, M or T. func isTestFunc(fn *ast.FuncDecl, arg string) bool { if fn.Type.Results != nil && len(fn.Type.Results.List) > 0 || fn.Type.Params.List == nil || @@ -575,7 +575,7 @@ func isTestFunc(fn *ast.FuncDecl, arg string) bool { // We can't easily check that the type is *testing.M // because we don't know how testing has been imported, // but at least check that it's *M or *something.M. - // Same applies for B and T. + // Same applies for B, F and T. if name, ok := ptr.X.(*ast.Ident); ok && name.Name == arg { return true }