1
0
mirror of https://github.com/golang/go synced 2024-09-29 14:24:32 -06:00

path/filepath: simplify EvalSymlinks for plan9

Plan 9 doesn't have symbolic links, so EvalSymlinks can be simplified
just to check validity of the path and call Clean. This saves a lot
of redundant file system activity.

Updates #50775

Change-Id: I84c24ef1d5e6e38fd19df2d37c72fbf883f0140d
Reviewed-on: https://go-review.googlesource.com/c/go/+/404954
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: David du Colombier <0intro@gmail.com>
Reviewed-by: David du Colombier <0intro@gmail.com>
This commit is contained in:
miller 2022-05-08 13:29:27 +01:00 committed by David du Colombier
parent c4311a47a0
commit 5020397677
2 changed files with 28 additions and 1 deletions

View File

@ -0,0 +1,27 @@
// Copyright 2022 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package filepath
import (
"os"
"strings"
"syscall"
)
func evalSymlinks(path string) (string, error) {
// Plan 9 doesn't have symbolic links, so no need for substitutions.
if len(path) > 0 {
// Check validity of path
_, err := os.Lstat(path)
if err != nil {
// Return the same error value as on other operating systems
if strings.HasSuffix(err.Error(), "not a directory") {
err = syscall.ENOTDIR
}
return "", err
}
}
return Clean(path), nil
}

View File

@ -1,4 +1,4 @@
//go:build !windows
//go:build !windows && !plan9
package filepath