qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 03:34:40 -07:00
Code Releases Activity

avoid an allocation inside bytes.Buffer by providing a static array.

Browse Source 
R=rsc
https://golang.org/cl/165058
This commit is contained in:
Rob Pike 2009-12-04 00:26:08 -08:00
parent f2c7a20142
commit 4ed57173b4
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/pkg/bytes/buffer.go
View File

@ -32,9 +32,9 @@ func copyBytes(dst []byte, doff int, src []byte) {
// with Read and Write methods.
// The zero value for Buffer is an empty buffer ready to use.
type Buffer struct {
buf []byte; // contents are the bytes buf[off : len(buf)]
off int; // read at &buf[off], write at &buf[len(buf)]
oneByte []byte; // avoid allocation of slice on each WriteByte
buf []byte; // contents are the bytes buf[off : len(buf)]
off int; // read at &buf[off], write at &buf[len(buf)]
oneByte [1]byte; // avoid allocation of slice on each WriteByte
}
// Bytes returns the contents of the unread portion of the buffer;
@ -173,12 +173,8 @@ func (b *Buffer) WriteString(s string) (n int, err os.Error) {
// The returned error is always nil, but is included
// to match bufio.Writer's WriteByte.
func (b *Buffer) WriteByte(c byte) os.Error {
if b.oneByte == nil {
// Only happens once per Buffer, and then we have a slice.
b.oneByte = make([]byte, 1)
}
b.oneByte[0] = c;
b.Write(b.oneByte);
b.Write(&b.oneByte);
return nil;
}