qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-30 11:28:36 -06:00
Code Releases Activity

cmd/go: accept smart quotes when checking for missing gold in TestNoteReading

Browse Source 
Fixes #39157

Change-Id: Ia983f5e66698519cd19c1565cfb80e86d08fdfc6
Reviewed-on: https://go-review.googlesource.com/c/go/+/234380
Reviewed-by: Ian Lance Taylor <iant@golang.org>
This commit is contained in:
Michael Hudson-Doyle 2020-05-20 14:39:13 +12:00
parent 13617380ca
commit 4ec4a792f6
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/note_test.go
View File

@ -53,7 +53,7 @@ func TestNoteReading(t *testing.T) {
// we've had trouble reading the notes generated by gold.
err := tg.doRun([]string{"build", "-ldflags", "-buildid=" + buildID + " -linkmode=external -extldflags=-fuse-ld=gold", "-o", tg.path("hello3.exe"), tg.path("hello.go")})
if err != nil {
if tg.grepCountBoth("(invalid linker|gold|cannot find 'ld')") > 0 {
if tg.grepCountBoth("(invalid linker|gold|cannot find [‘']ld[’'])") > 0 {
// It's not an error if gold isn't there. gcc claims it "cannot find 'ld'" if
// ld.gold is missing, see issue #22340.
t.Log("skipping gold test")