From 4d3d333468b6a36106550bf90d93b3cc88b1efa4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Mart=C3=AD?= Date: Sat, 23 Sep 2017 21:44:18 +0100 Subject: [PATCH] cmd/compile: add runtime GC funcs to inlining test MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This is based on a list that Austin Clements provided in mid-2016. It is mostly untouched, except for the fact that the wbufptr funcs were removed from the runtime thus removed from the lits here too. Add a section for these GC funcs, since there are quite a lot of them and the runtime has tons of funcs that we want to inline. As before, sort this section too. Also place some of these funcs out of the GC section, as they are not directly related to the GC. Updates #21851. Change-Id: I35eb777a4c50b5f655618920dc2bc568c7c30ff5 Reviewed-on: https://go-review.googlesource.com/65654 Run-TryBot: Daniel Martí TryBot-Result: Gobot Gobot Reviewed-by: Austin Clements --- src/cmd/compile/internal/gc/inl_test.go | 31 +++++++++++++++++++++++++ 1 file changed, 31 insertions(+) diff --git a/src/cmd/compile/internal/gc/inl_test.go b/src/cmd/compile/internal/gc/inl_test.go index d6e61af9b3..426417ce79 100644 --- a/src/cmd/compile/internal/gc/inl_test.go +++ b/src/cmd/compile/internal/gc/inl_test.go @@ -34,6 +34,8 @@ func TestIntendedInlining(t *testing.T) { // "adjustctxt", "add", + "acquirem", + "add1", "addb", "adjustpanics", "adjustpointer", @@ -46,6 +48,7 @@ func TestIntendedInlining(t *testing.T) { "fastlog2", "fastrand", "float64bits", + "funcPC", "getm", "isDirectIface", "itabHashFunc", @@ -53,15 +56,43 @@ func TestIntendedInlining(t *testing.T) { "noescape", "readUnaligned32", "readUnaligned64", + "releasem", "round", "roundupsize", + "selectsize", "stringStructOf", + "subtract1", "subtractb", "tophash", "totaldefersize", "(*bmap).keys", "(*bmap).overflow", "(*waitq).enqueue", + + // GC-related ones + "cgoInRange", + "gclinkptr.ptr", + "guintptr.ptr", + "heapBits.bits", + "heapBits.isPointer", + "heapBits.morePointers", + "heapBits.next", + "heapBitsForAddr", + "inheap", + "markBits.isMarked", + "muintptr.ptr", + "puintptr.ptr", + "spanOfUnchecked", + "(*gcWork).putFast", + "(*gcWork).tryGetFast", + "(*guintptr).set", + "(*markBits).advance", + "(*mspan).allocBitsForIndex", + "(*mspan).base", + "(*mspan).markBitsForBase", + "(*mspan).markBitsForIndex", + "(*muintptr).set", + "(*puintptr).set", }, "runtime/internal/sys": {}, "bytes": {