qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 20:20:23 -07:00
Code Releases Activity

strconv: fix Eisel-Lemire for negative zero

Browse Source 
This is somewhat academic (and no tests failed before this commit),
since func atof64 only calls func eiselLemire when func atof64exact
fails, and func atof64exact doesn't fail when parsing positive or
negative zeroes. But it's still worth fixing.

Change-Id: Ibe6ef4c8fd96827673b711d5456003fbc447e39c
Reviewed-on: https://go-review.googlesource.com/c/go/+/264140
Trust: Nigel Tao <nigeltao@golang.org>
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Nigel Tao 2020-10-22 23:59:00 +11:00
parent c92bfac01e
commit 4ce9ea52c9
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/strconv/eisel_lemire.go
View File

@ -22,14 +22,17 @@ import (
"math/bits"
)
func eiselLemire(man uint64, exp10 int, neg bool) (ret float64, ok bool) {
func eiselLemire(man uint64, exp10 int, neg bool) (f float64, ok bool) {
// The terse comments in this function body refer to sections of the
// https://nigeltao.github.io/blog/2020/eisel-lemire.html blog post.
// Exp10 Range.
const exp10Min, exp10Max = -307, +288
if man == 0 {
return 0, true
if neg {
f = math.Float64frombits(0x80000000_00000000) // Negative zero.
}
return f, true
}
if exp10 < exp10Min || exp10Max < exp10 {
return 0, false