qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-27 03:11:19 -07:00
Code Releases Activity

time: handle int64 overflow in ParseDuration.

Browse Source 
Previously, passing a long duration to ParseDuration could result in
random, even negative, values.

LGTM=r
R=golang-codereviews, bradfitz, r
CC=golang-codereviews
https://golang.org/cl/72120043
This commit is contained in:
Adam Langley 2014-03-10 12:33:45 -04:00
parent 4bc632cead
commit 4ca6e588e4
2 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/pkg/time/format.go
View File

@ -1240,5 +1240,8 @@ func ParseDuration(s string) (Duration, error) {
if neg { if neg {
f = -f f = -f
} }
if f < float64(-1<<63) || f > float64(1<<63-1) {
return 0, errors.New("time: overflow parsing duration")
}
return Duration(f), nil return Duration(f), nil
} }

1
src/pkg/time/time_test.go
View File

@ -842,6 +842,7 @@ var parseDurationTests = []struct {
{"-.", false, 0}, {"-.", false, 0},
{".s", false, 0}, {".s", false, 0},
{"+.s", false, 0}, {"+.s", false, 0},
{"3000000h", false, 0}, // overflow
} }
func TestParseDuration(t *testing.T) { func TestParseDuration(t *testing.T) {