From 4c473c02e13f2429c7776cc6585af420cd248502 Mon Sep 17 00:00:00 2001 From: Shenghou Ma Date: Thu, 11 Oct 2012 23:33:57 +0800 Subject: [PATCH] doc/contribute.html: assorted fixes 0. windows uses all.bat instead of ./all.bash 1. correct expected all.bash output 2. mention you need to use an application specific password if you're using 2-step verification 3. note you can edit files included in CL by 'hg change NNNN' or 'hg file' R=golang-dev, adg, r CC=golang-dev https://golang.org/cl/6615060 --- doc/contribute.html | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/doc/contribute.html b/doc/contribute.html index 83206579049..683c3873731 100644 --- a/doc/contribute.html +++ b/doc/contribute.html @@ -46,24 +46,13 @@ tree to make sure the changes don't break other packages or programs: 
 cd $GOROOT/src
-./all.bash
+./all.bash    # On Windows, run all.bat

-The final line printed by make all should be of the form: +After running for a while, the command should print "ALL TESTS PASSED".

-
-N known bugs; 0 unexpected bugs
-
- -

-The value of N varies over time, but the line must -say “0 unexpected bugs” and must not -add “test output differs.” -

- -

Code review

@@ -133,6 +122,8 @@ will be recorded in the Mercur and in the CONTRIBUTORS file. You can create a Google Account associated with any address where you receive email. +If you've enabled the two-step verification feature, don't forget to generate an +application-specific password and use that when prompted for a password. 

@@ -285,8 +276,10 @@ CL created: http://codereview.appspot.com/99999

-If you need to re-edit the change description, -run hg change 99999. +If you need to re-edit the change description, or change the files included in the CL, +run hg change 99999. Alternatively, you can use hg file 99999 somefile +to add somefile to CL 99999, and use hg file -d 99999 somefile to remove +somefile from the CL.