qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 20:40:23 -07:00
Code Releases Activity

gc: simplify complex typecheck

Browse Source 
do not convert to float prematurely.

R=ken2
CC=golang-dev
https://golang.org/cl/311041
This commit is contained in:
Russ Cox 2010-03-08 15:44:18 -08:00
parent 4f89dcdf99
commit 4ac011a011
3 changed files with 37 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/cmd/gc/const.c
View File

@ -888,6 +888,9 @@ nodcplxlit(Val r, Val i)
Node *n;
Mpcplx *c;
r = toflt(r);
i = toflt(i);
c = mal(sizeof(*c));
n = nod(OLITERAL, N, N);
n->type = types[TIDEAL];

20
src/cmd/gc/print.c
View File

@ -309,6 +309,26 @@ exprfmt(Fmt *f, Node *n, int prec)
fmtprint(f, ")");
break;
case OCMPLX:
fmtprint(f, "cmplx(");
exprfmt(f, n->left, 0);
fmtprint(f, ", ");
exprfmt(f, n->right, 0);
fmtprint(f, ")");
break;
case OREAL:
fmtprint(f, "real(");
exprfmt(f, n->left, 0);
fmtprint(f, ")");
break;
case OIMAG:
fmtprint(f, "imag(");
exprfmt(f, n->left, 0);
fmtprint(f, ")");
break;
case OCONV:
case OCONVNOP:
case OCONVSLICE:

41
src/cmd/gc/typecheck.c
View File

@ -788,17 +788,19 @@ reswitch:
if(l->type == T || r->type == T)
goto error;
defaultlit2(&l, &r, 0);
if(l->op == OLITERAL && r->op == OLITERAL) {
// make it a complex literal
n->left = l;
n->right = r;
if(l->type->etype != l->type->etype) {
badcmplx:
yyerror("invalid operation: %#N (cmplx of types %T, %T)", n, l->type, r->type);
goto error;
}
switch(l->type->etype) {
default:
yyerror("real and imag parts must be the floating");
goto error;
goto badcmplx;
case TIDEAL:
convlit(&l, types[TFLOAT]);
convlit(&r, types[TFLOAT]);
t = types[TIDEAL];
// fallthrough
break;
case TFLOAT:
t = types[TCOMPLEX];
break;
@ -809,31 +811,12 @@ reswitch:
t = types[TCOMPLEX128];
break;
}
if(l->op == OLITERAL && r->op == OLITERAL) {
// make it a complex literal
n = nodcplxlit(l->val, r->val);
}
n->type = t;
goto ret;
}
n->left = l;
n->right = r;
if(l->type->etype != l->type->etype) {
yyerror("real and imag parts must be the same type");
goto error;
}
switch(l->type->etype) {
default:
yyerror("real and imag parts must be the floating");
goto error;
case TFLOAT:
n->type = types[TCOMPLEX];
break;
case TFLOAT32:
n->type = types[TCOMPLEX64];
break;
case TFLOAT64:
n->type = types[TCOMPLEX128];
break;
}
goto ret;
case OCLOSED:
case OCLOSE: