qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-25 05:10:12 -06:00
Code Releases Activity

cmd/compile: remove vet-blocking hack

Browse Source 
...and add the vet failures to the vet whitelist.

Change-Id: Idcf4289f39dda561c85f3b0afe396e5299e6495f
Reviewed-on: https://go-review.googlesource.com/127995
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
This commit is contained in:
Keith Randall 2018-08-06 10:42:28 -07:00 committed by Keith Randall
parent 707fd452e6
commit 4a4e3b0bc7
2 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmd/compile/internal/gc/testdata/novet.go vendored
View File

@ -1,9 +0,0 @@
// Copyright 2018 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// This file exists just to convince vet not to check this directory.
// (vet will not check a directory with two different packages in it.)
// TODO: remove this hack & add failing tests to the whitelist.
package foo

19
src/cmd/vet/all/whitelist/all.txt
View File

@ -28,6 +28,25 @@ encoding/json/tagkey_test.go: struct field tag `:"BadFormat"` not compatible wit
runtime/testdata/testprog/deadlock.go: unreachable code
runtime/testdata/testprog/deadlock.go: unreachable code
// Compiler tests that make sure even vet-failing code adheres to the spec.
cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
cmd/compile/internal/gc/testdata/arithConst_test.go: a (64 bits) too small for shift of 4294967296
cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
cmd/compile/internal/gc/testdata/arithConst_test.go: a (32 bits) too small for shift of 4294967295
cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
cmd/compile/internal/gc/testdata/arithConst_test.go: a (16 bits) too small for shift of 65535
cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
cmd/compile/internal/gc/testdata/arithConst_test.go: a (8 bits) too small for shift of 255
cmd/compile/internal/gc/testdata/arith_test.go: x (64 bits) too small for shift of 100
cmd/compile/internal/gc/testdata/arith_test.go: int32(x) (32 bits) too small for shift of 4294967295
cmd/compile/internal/gc/testdata/arith_test.go: int16(x) (16 bits) too small for shift of 65535
cmd/compile/internal/gc/testdata/arith_test.go: int8(x) (8 bits) too small for shift of 255
cmd/compile/internal/gc/testdata/arith_test.go: w (32 bits) too small for shift of 32
cmd/compile/internal/gc/testdata/break_test.go: unreachable code
cmd/compile/internal/gc/testdata/break_test.go: unreachable code
cmd/compile/internal/gc/testdata/namedReturn_test.go: self-assignment of t to t
cmd/compile/internal/gc/testdata/short_test.go: unreachable code
// Non-standard method signatures.
// These cases are basically ok.
// Errors are handled reasonably and there's no clear need for interface satisfaction.