qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 18:54:43 -07:00
Code Releases Activity

codereview: make sure each mail has a reviewer

Browse Source 
R=r
CC=golang-dev
https://golang.org/cl/196050
This commit is contained in:
Russ Cox 2010-01-28 12:48:21 -08:00
parent 2e989df0fb
commit 4967f857d5
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/codereview/codereview.py
View File

@ -960,8 +960,16 @@ def mail(ui, repo, *pats, **opts):
if err != "": if err != "":
return err return err
cl.Upload(ui, repo, gofmt_just_warn=True) cl.Upload(ui, repo, gofmt_just_warn=True)
if not cl.reviewer and not cl.cc: if not cl.reviewer:
# If no reviewer is listed, assign the review to defaultcc.
# This makes sure that it appears in the
# codereview.appspot.com/user/defaultcc
# page, so that it doesn't get dropped on the floor.
if not defaultcc:
return "no reviewers listed in CL" return "no reviewers listed in CL"
cl.cc = Sub(cl.cc, defaultcc)
cl.reviewer = defaultcc
cl.Flush(ui, repo)
cl.Mail(ui, repo) cl.Mail(ui, repo)
def nocommit(ui, repo, *pats, **opts): def nocommit(ui, repo, *pats, **opts):