mirror of
https://github.com/golang/go
synced 2024-10-01 05:38:32 -06:00
runtime: relax flaky GC pause test
We often saw GC pauses of 0 ns, not just on Windows. Google Compute Engine timer granularity might suck too. LGTM=rsc R=rsc, dvyukov CC=golang-codereviews https://golang.org/cl/140910043
This commit is contained in:
parent
176c44699b
commit
4930a8d058
@ -165,9 +165,12 @@ func TestGcLastTime(t *testing.T) {
|
||||
t.Fatalf("bad last GC time: got %v, want [%v, %v]", last, t0, t1)
|
||||
}
|
||||
pause := ms.PauseNs[(ms.NumGC+255)%256]
|
||||
// Due to timer granularity pause can actually be 0 on windows.
|
||||
if (pause == 0 && runtime.GOOS != "windows") || pause > 10e9 {
|
||||
t.Fatalf("bad last GC pause: got %v, want [0, 10e9]", pause)
|
||||
// Due to timer granularity, pause can actually be 0 on windows
|
||||
// or on virtualized environments.
|
||||
if pause == 0 {
|
||||
t.Logf("last GC pause was 0")
|
||||
} else if pause > 10e9 {
|
||||
t.Logf("bad last GC pause: got %v, want [0, 10e9]", pause)
|
||||
}
|
||||
}
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user