qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-09-28 21:34:30 -06:00
Code Releases Activity

internal/bisect: replace atomicPointerDedup to simplify the code

Browse Source 
"atomicPointerDedup" is a redundancy of "atomic.Pointer".

Since Go 1.22 now requires the final point release of Go 1.20  or
later for bootstrap, Go 1.19's atomic.Pointer can be used
without problems.

atomicPointerDedup is unnecessary and we can remove it now.

Change-Id: I0a65ad0b6649cecb73d58dc39c5fd736390d5fa5
GitHub-Last-Rev: 6c6e9421fb
GitHub-Pull-Request: golang/go#65987
Reviewed-on: https://go-review.googlesource.com/c/go/+/567656
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This commit is contained in:
apocelipes 2024-03-14 12:55:10 +00:00 committed by Gopher Robot
parent c764d56ff1
commit 49204af37e
1 changed files with 1 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/internal/bisect/bisect.go
View File

@ -180,7 +180,6 @@ import (
"runtime"
"sync"
"sync/atomic"
"unsafe"
)
// New creates and returns a new Matcher implementing the given pattern.
@ -311,22 +310,7 @@ type Matcher struct {
quiet bool // disables all reporting. reset if verbose is true. use case is -d=fmahash=qn
enable bool // when true, list is for “enable and report” (when false, “disable and report”)
list []cond // conditions; later ones win over earlier ones
dedup atomicPointerDedup
}
// atomicPointerDedup is an atomic.Pointer[dedup],
// but we are avoiding using Go 1.19's atomic.Pointer
// until the bootstrap toolchain can be relied upon to have it.
type atomicPointerDedup struct {
p unsafe.Pointer
}
func (p *atomicPointerDedup) Load() *dedup {
return (*dedup)(atomic.LoadPointer(&p.p))
}
func (p *atomicPointerDedup) CompareAndSwap(old, new *dedup) bool {
return atomic.CompareAndSwapPointer(&p.p, unsafe.Pointer(old), unsafe.Pointer(new))
dedup atomic.Pointer[dedup]
}
// A cond is a single condition in the matcher.