qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-23 07:20:06 -07:00
Code Releases Activity

cmd/go: fix long test builders

Browse Source 
CL 343732 enabled -G=3 by default. The types2 typechecker uses slighly
different error message format for language feature constraint.

The old typechecker format:

	vendor/example.net/need117/need117.go:5:16: cannot convert s (type []byte) to type *[4]byte:
		conversion of slices to array pointers only supported as of -lang=go1.17

The new format:

	vendor/example.net/need117/need117.go:5:17: conversion of slices to array pointers only supported as of -lang=go1.17

caused the long test builders failed.

This CL fixes the test by relaxing the regext pattern a bit, so it can
match both the format.

Change-Id: I1c4acaa9e34b6c08dccbbc3ce7a99d4cd79f748a
Reviewed-on: https://go-review.googlesource.com/c/go/+/344212
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Trust: Robert Griesemer <gri@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
This commit is contained in:
Cuong Manh Le 2021-08-23 09:31:54 +07:00
parent 86ee89225a
commit 457418b475
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/go/testdata/script/mod_vendor_goversion.txt vendored
View File

@ -26,7 +26,7 @@ go mod vendor
! grep 1.17 vendor/modules.txt ! grep 1.17 vendor/modules.txt
! go build example.net/need117 ! go build example.net/need117
stderr '^vendor[/\\]example\.net[/\\]need117[/\\]need117.go:5:18: .*\n\tconversion of slices to array pointers only supported as of -lang=go1\.17' stderr '^vendor[/\\]example\.net[/\\]need117[/\\]need117.go:5:1[89]: .*conversion of slices to array pointers only supported as of -lang=go1\.17'
! grep 1.13 vendor/modules.txt ! grep 1.13 vendor/modules.txt
go build example.net/bad114 go build example.net/bad114