qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 07:54:41 -07:00
Code Releases Activity

crypto/ecdsa: improve benchmarks

Browse Source 
While at it, drop P-224 benchmarks. Nobody cares about P-224.

Change-Id: I31db6fedde6026deff36de963690275dacf5fda1
Reviewed-on: https://go-review.googlesource.com/c/go/+/451196
Auto-Submit: Filippo Valsorda <filippo@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Joedian Reid <joedian@golang.org>
Run-TryBot: Filippo Valsorda <filippo@golang.org>
This commit is contained in:
Filippo Valsorda 2022-11-14 18:43:43 +01:00 committed by Gopher Robot
parent d6171c9be2
commit 4571164537
1 changed files with 9 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/crypto/ecdsa/ecdsa_test.go
View File

@ -333,7 +333,6 @@ func benchmarkAllCurves(b *testing.B, f func(*testing.B, elliptic.Curve)) {
curve elliptic.Curve
}{
{"P256", elliptic.P256()},
{"P224", elliptic.P224()},
{"P384", elliptic.P384()},
{"P521", elliptic.P521()},
}
@ -347,7 +346,8 @@ func benchmarkAllCurves(b *testing.B, f func(*testing.B, elliptic.Curve)) {
func BenchmarkSign(b *testing.B) {
benchmarkAllCurves(b, func(b *testing.B, curve elliptic.Curve) {
priv, err := GenerateKey(curve, rand.Reader)
r := bufio.NewReaderSize(rand.Reader, 1<<15)
priv, err := GenerateKey(curve, r)
if err != nil {
b.Fatal(err)
}
@ -356,7 +356,7 @@ func BenchmarkSign(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
sig, err := SignASN1(rand.Reader, priv, hashed)
sig, err := SignASN1(r, priv, hashed)
if err != nil {
b.Fatal(err)
}
@ -368,12 +368,13 @@ func BenchmarkSign(b *testing.B) {
func BenchmarkVerify(b *testing.B) {
benchmarkAllCurves(b, func(b *testing.B, curve elliptic.Curve) {
priv, err := GenerateKey(curve, rand.Reader)
r := bufio.NewReaderSize(rand.Reader, 1<<15)
priv, err := GenerateKey(curve, r)
if err != nil {
b.Fatal(err)
}
hashed := []byte("testing")
r, s, err := Sign(rand.Reader, priv, hashed)
sig, err := SignASN1(r, priv, hashed)
if err != nil {
b.Fatal(err)
}
@ -381,7 +382,7 @@ func BenchmarkVerify(b *testing.B) {
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
if !Verify(&priv.PublicKey, hashed, r, s) {
if !VerifyASN1(&priv.PublicKey, hashed, sig) {
b.Fatal("verify failed")
}
}
@ -390,10 +391,11 @@ func BenchmarkVerify(b *testing.B) {
func BenchmarkGenerateKey(b *testing.B) {
benchmarkAllCurves(b, func(b *testing.B, curve elliptic.Curve) {
r := bufio.NewReaderSize(rand.Reader, 1<<15)
b.ReportAllocs()
b.ResetTimer()
for i := 0; i < b.N; i++ {
if _, err := GenerateKey(curve, rand.Reader); err != nil {
if _, err := GenerateKey(curve, r); err != nil {
b.Fatal(err)
}
}