From 45301ba8c04cca3501d2324a7e30481e3ce022c0 Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Mon, 26 Sep 2011 20:46:37 -0700 Subject: [PATCH] runtime: check for nil value pointer in select syncsend case Fixes #2309. R=rsc, bradfitz CC=golang-dev https://golang.org/cl/5128053 --- src/pkg/runtime/chan.c | 3 +- test/chan/select7.go | 68 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 70 insertions(+), 1 deletion(-) create mode 100644 test/chan/select7.go diff --git a/src/pkg/runtime/chan.c b/src/pkg/runtime/chan.c index eac2098c39..cc056f65f1 100644 --- a/src/pkg/runtime/chan.c +++ b/src/pkg/runtime/chan.c @@ -1024,7 +1024,8 @@ syncsend: selunlock(sel); if(debug) runtime·printf("syncsend: sel=%p c=%p o=%d\n", sel, c, o); - c->elemalg->copy(c->elemsize, sg->elem, cas->sg.elem); + if(sg->elem != nil) + c->elemalg->copy(c->elemsize, sg->elem, cas->sg.elem); gp = sg->g; gp->param = sg; runtime·ready(gp); diff --git a/test/chan/select7.go b/test/chan/select7.go new file mode 100644 index 0000000000..5fed6cbd42 --- /dev/null +++ b/test/chan/select7.go @@ -0,0 +1,68 @@ +// $G $D/$F.go && $L $F.$A && ./$A.out + +// Copyright 2011 The Go Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +// Test select when discarding a value. + +package main + +import "runtime" + +func recv1(c <-chan int) { + <-c +} + +func recv2(c <-chan int) { + select { + case <-c: + } +} + +func recv3(c <-chan int) { + c2 := make(chan int) + select { + case <-c: + case <-c2: + } +} + +func send1(recv func(<-chan int)) { + c := make(chan int) + go recv(c) + runtime.Gosched() + c <- 1 +} + +func send2(recv func(<-chan int)) { + c := make(chan int) + go recv(c) + runtime.Gosched() + select { + case c <- 1: + } +} + +func send3(recv func(<-chan int)) { + c := make(chan int) + go recv(c) + runtime.Gosched() + c2 := make(chan int) + select { + case c <- 1: + case c2 <- 1: + } +} + +func main() { + send1(recv1) + send2(recv1) + send3(recv1) + send1(recv2) + send2(recv2) + send3(recv2) + send1(recv3) + send2(recv3) + send3(recv3) +}