From 43c390a1fabfa5eb81529f399bb4d1875f1ca35d Mon Sep 17 00:00:00 2001 From: Filippo Valsorda Date: Wed, 5 May 2021 21:32:04 -0400 Subject: [PATCH] crypto/ed25519: skip allocations test on -noopt builder Without optimizations, there will be unexpected allocations. Change-Id: I90dc2636279b7fda7689eabc763251c4cdd25874 Reviewed-on: https://go-review.googlesource.com/c/go/+/317370 Trust: Filippo Valsorda Run-TryBot: Filippo Valsorda TryBot-Result: Go Bot Reviewed-by: Emmanuel Odeke --- src/crypto/ed25519/ed25519_test.go | 3 +++ .../ed25519/internal/edwards25519/edwards25519_test.go | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/src/crypto/ed25519/ed25519_test.go b/src/crypto/ed25519/ed25519_test.go index ba9970e23e5..8a973b36eaf 100644 --- a/src/crypto/ed25519/ed25519_test.go +++ b/src/crypto/ed25519/ed25519_test.go @@ -186,6 +186,9 @@ func TestMalleability(t *testing.T) { } func TestAllocations(t *testing.T) { + if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-noopt") { + t.Skip("skipping allocations test without relevant optimizations") + } if allocs := testing.AllocsPerRun(100, func() { seed := make([]byte, SeedSize) message := []byte("Hello, world!") diff --git a/src/crypto/ed25519/internal/edwards25519/edwards25519_test.go b/src/crypto/ed25519/internal/edwards25519/edwards25519_test.go index ac7c78c0867..8031256525a 100644 --- a/src/crypto/ed25519/internal/edwards25519/edwards25519_test.go +++ b/src/crypto/ed25519/internal/edwards25519/edwards25519_test.go @@ -7,7 +7,9 @@ package edwards25519 import ( "crypto/ed25519/internal/edwards25519/field" "encoding/hex" + "os" "reflect" + "strings" "testing" ) @@ -279,6 +281,9 @@ func TestNonCanonicalPoints(t *testing.T) { var testAllocationsSink byte func TestAllocations(t *testing.T) { + if strings.HasSuffix(os.Getenv("GO_BUILDER_NAME"), "-noopt") { + t.Skip("skipping allocations test without relevant optimizations") + } if allocs := testing.AllocsPerRun(100, func() { p := NewIdentityPoint() p.Add(p, NewGeneratorPoint())