mirror of
https://github.com/golang/go
synced 2024-10-03 06:21:21 -06:00
gofmt: test rewrite of (x.(type)) -> x.(type)
R=rsc CC=golang-dev https://golang.org/cl/6867062
This commit is contained in:
parent
485673188d
commit
42a854b746
@ -83,7 +83,8 @@ var tests = []struct {
|
||||
{"testdata/stdin*.input", "-stdin"},
|
||||
{"testdata/comments.input", ""},
|
||||
{"testdata/import.input", ""},
|
||||
{"testdata/crlf.input", ""}, // test case for issue 3961; see also TestCRLF
|
||||
{"testdata/crlf.input", ""}, // test case for issue 3961; see also TestCRLF
|
||||
{"testdata/typeswitch.input", ""}, // test case for issue 4470
|
||||
}
|
||||
|
||||
func TestRewrite(t *testing.T) {
|
||||
|
60
src/cmd/gofmt/testdata/typeswitch.golden
vendored
Normal file
60
src/cmd/gofmt/testdata/typeswitch.golden
vendored
Normal file
@ -0,0 +1,60 @@
|
||||
/*
|
||||
Parenthesized type switch expressions originally
|
||||
accepted by gofmt must continue to be rewritten
|
||||
into the correct unparenthesized form.
|
||||
|
||||
Only type-switches that didn't declare a variable
|
||||
in the the type switch type assertion and which
|
||||
contained only "expression-like" (named) types in their
|
||||
cases were permitted to have their type assertion parenthesized
|
||||
by go/parser (due to a weak predicate in the parser). All others
|
||||
were rejected always, either with a syntax error in the
|
||||
type switch header or in the case.
|
||||
|
||||
See also issue 4470.
|
||||
*/
|
||||
package p
|
||||
|
||||
func f() {
|
||||
var x interface{}
|
||||
switch x.(type) { // should remain the same
|
||||
}
|
||||
switch x.(type) { // should become: switch x.(type) {
|
||||
}
|
||||
|
||||
switch x.(type) { // should remain the same
|
||||
case int:
|
||||
}
|
||||
switch x.(type) { // should become: switch x.(type) {
|
||||
case int:
|
||||
}
|
||||
|
||||
switch x.(type) { // should remain the same
|
||||
case []int:
|
||||
}
|
||||
|
||||
// Parenthesized (x.(type)) in type switches containing cases
|
||||
// with unnamed (literal) types were never permitted by gofmt;
|
||||
// thus there won't be any code in the wild using this style if
|
||||
// the code was gofmt-ed.
|
||||
/*
|
||||
switch (x.(type)) {
|
||||
case []int:
|
||||
}
|
||||
*/
|
||||
|
||||
switch t := x.(type) { // should remain the same
|
||||
default:
|
||||
_ = t
|
||||
}
|
||||
|
||||
// Parenthesized (x.(type)) in type switches declaring a variable
|
||||
// were never permitted by gofmt; thus there won't be any code in
|
||||
// the wild using this style if the code was gofmt-ed.
|
||||
/*
|
||||
switch t := (x.(type)) {
|
||||
default:
|
||||
_ = t
|
||||
}
|
||||
*/
|
||||
}
|
60
src/cmd/gofmt/testdata/typeswitch.input
vendored
Normal file
60
src/cmd/gofmt/testdata/typeswitch.input
vendored
Normal file
@ -0,0 +1,60 @@
|
||||
/*
|
||||
Parenthesized type switch expressions originally
|
||||
accepted by gofmt must continue to be rewritten
|
||||
into the correct unparenthesized form.
|
||||
|
||||
Only type-switches that didn't declare a variable
|
||||
in the the type switch type assertion and which
|
||||
contained only "expression-like" (named) types in their
|
||||
cases were permitted to have their type assertion parenthesized
|
||||
by go/parser (due to a weak predicate in the parser). All others
|
||||
were rejected always, either with a syntax error in the
|
||||
type switch header or in the case.
|
||||
|
||||
See also issue 4470.
|
||||
*/
|
||||
package p
|
||||
|
||||
func f() {
|
||||
var x interface{}
|
||||
switch x.(type) { // should remain the same
|
||||
}
|
||||
switch (x.(type)) { // should become: switch x.(type) {
|
||||
}
|
||||
|
||||
switch x.(type) { // should remain the same
|
||||
case int:
|
||||
}
|
||||
switch (x.(type)) { // should become: switch x.(type) {
|
||||
case int:
|
||||
}
|
||||
|
||||
switch x.(type) { // should remain the same
|
||||
case []int:
|
||||
}
|
||||
|
||||
// Parenthesized (x.(type)) in type switches containing cases
|
||||
// with unnamed (literal) types were never permitted by gofmt;
|
||||
// thus there won't be any code in the wild using this style if
|
||||
// the code was gofmt-ed.
|
||||
/*
|
||||
switch (x.(type)) {
|
||||
case []int:
|
||||
}
|
||||
*/
|
||||
|
||||
switch t := x.(type) { // should remain the same
|
||||
default:
|
||||
_ = t
|
||||
}
|
||||
|
||||
// Parenthesized (x.(type)) in type switches declaring a variable
|
||||
// were never permitted by gofmt; thus there won't be any code in
|
||||
// the wild using this style if the code was gofmt-ed.
|
||||
/*
|
||||
switch t := (x.(type)) {
|
||||
default:
|
||||
_ = t
|
||||
}
|
||||
*/
|
||||
}
|
Loading…
Reference in New Issue
Block a user