qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 05:47:57 -07:00
Code Releases Activity

windows: fix netchan test by using 127.0.0.1.

Browse Source 
Re-enable the test on Windows.

R=brainman, alex.brainman
CC=golang-dev
https://golang.org/cl/2244041
This commit is contained in:
Rob Pike 2010-09-18 11:43:10 +10:00
parent 289432daff
commit 42a61b920e
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/pkg/Makefile
View File

@ -189,7 +189,6 @@ endif
# Disable tests that windows cannot run yet. # Disable tests that windows cannot run yet.
ifeq ($(GOOS),windows) ifeq ($(GOOS),windows)
NOTEST+=exec # no pipe NOTEST+=exec # no pipe
NOTEST+=netchan # net.Dial("tcp", "", "0.0.0.0:80") doesn't work on windows
NOTEST+=os # many things unimplemented NOTEST+=os # many things unimplemented
NOTEST+=os/signal # no signals NOTEST+=os/signal # no signals
NOTEST+=path # tree walking does not work NOTEST+=path # tree walking does not work

4
src/pkg/netchan/netchan_test.go
View File

@ -151,7 +151,7 @@ type value struct {
// This test cross-connects a pair of exporter/importer pairs. // This test cross-connects a pair of exporter/importer pairs.
func TestCrossConnect(t *testing.T) { func TestCrossConnect(t *testing.T) {
e1, err := NewExporter("tcp", ":0") e1, err := NewExporter("tcp", "127.0.0.1:0")
if err != nil { if err != nil {
t.Fatal("new exporter:", err) t.Fatal("new exporter:", err)
} }
@ -160,7 +160,7 @@ func TestCrossConnect(t *testing.T) {
t.Fatal("new importer:", err) t.Fatal("new importer:", err)
} }
e2, err := NewExporter("tcp", ":0") e2, err := NewExporter("tcp", "127.0.0.1:0")
if err != nil { if err != nil {
t.Fatal("new exporter:", err) t.Fatal("new exporter:", err)
} }