mirror of
https://github.com/golang/go
synced 2024-11-11 19:21:37 -07:00
cmd/compile: rewrite literal.method to ensure full initialization
CALLPART of STRUCTLIT did not check for incomplete initialization of struct; modify PTRLIT treatment to force zeroing. Test for structlit, believe this might have also failed for arraylit. Fixes #18410. Change-Id: I511abf8ef850e300996d40568944665714efe1fc Reviewed-on: https://go-review.googlesource.com/34622 Run-TryBot: David Chase <drchase@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
parent
a37b9e8e70
commit
41d2278eef
@ -1078,6 +1078,8 @@ func anylit(n *Node, var_ *Node, init *Nodes) {
|
|||||||
|
|
||||||
var r *Node
|
var r *Node
|
||||||
if n.Right != nil {
|
if n.Right != nil {
|
||||||
|
// n.Right is stack temporary used as backing store.
|
||||||
|
init.Append(nod(OAS, n.Right, nil)) // zero backing store, just in case (#18410)
|
||||||
r = nod(OADDR, n.Right, nil)
|
r = nod(OADDR, n.Right, nil)
|
||||||
r = typecheck(r, Erv)
|
r = typecheck(r, Erv)
|
||||||
} else {
|
} else {
|
||||||
|
40
test/fixedbugs/issue18410.go
Normal file
40
test/fixedbugs/issue18410.go
Normal file
@ -0,0 +1,40 @@
|
|||||||
|
// run
|
||||||
|
|
||||||
|
// Copyright 2016 The Go Authors. All rights reserved.
|
||||||
|
// Use of this source code is governed by a BSD-style
|
||||||
|
// license that can be found in the LICENSE file.
|
||||||
|
|
||||||
|
// This checks partially initialized structure literals
|
||||||
|
// used to create value.method functions have their
|
||||||
|
// non-initialized fields properly zeroed/nil'd
|
||||||
|
|
||||||
|
package main
|
||||||
|
|
||||||
|
type X struct {
|
||||||
|
A, B, C *int
|
||||||
|
}
|
||||||
|
|
||||||
|
//go:noinline
|
||||||
|
func (t X) Print() {
|
||||||
|
if t.B != nil {
|
||||||
|
panic("t.B must be nil")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
//go:noinline
|
||||||
|
func caller(f func()) {
|
||||||
|
f()
|
||||||
|
}
|
||||||
|
|
||||||
|
//go:noinline
|
||||||
|
func test() {
|
||||||
|
var i, j int
|
||||||
|
x := X{A: &i, C: &j}
|
||||||
|
caller(func() { X{A: &i, C: &j}.Print() })
|
||||||
|
caller(X{A: &i, C: &j}.Print)
|
||||||
|
caller(x.Print)
|
||||||
|
}
|
||||||
|
|
||||||
|
func main() {
|
||||||
|
test()
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user