qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-15 02:10:21 -07:00
Code Releases Activity

runtime/pprof: ignore runtime-internal samples in test

Browse Source 
Tests of the mutex profile focus on sync.Mutex, which is easy to
control. But since those tests still use the runtime, and contention on
internal runtime.mutex values is now also part of the mutex profile, we
have to filter out those samples before examining the profile. Otherwise
the test may be confused by stray contention on sched.lock (or other
runtime-internal locks) as a natural consequence of using goroutines.

Fixes #67563

Change-Id: I066a24674d8b719dbeca4a5c0f76b53bc07498c1
Reviewed-on: https://go-review.googlesource.com/c/go/+/586957
Reviewed-by: Cherry Mui <cherryyz@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Rhys Hiltner <rhys.hiltner@gmail.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
This commit is contained in:
Rhys Hiltner 2024-05-22 09:57:14 -07:00 committed by Gopher Robot
parent 3989bc8a80
commit 41884dcd05
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/runtime/pprof/pprof_test.go
View File

@ -1349,15 +1349,22 @@ func TestMutexProfileRateAdjust(t *testing.T) {
}
for _, s := range p.Sample {
var match, runtimeInternal bool
for _, l := range s.Location {
for _, line := range l.Line {
if line.Function.Name == "runtime/pprof.blockMutex.func1" {
match = true
}
if line.Function.Name == "runtime.unlock" {
runtimeInternal = true
}
}
}
if match && !runtimeInternal {
contentions += s.Value[0]
delay += s.Value[1]
}
}
}
}
return
}