qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-17 12:54:47 -07:00
Code Releases Activity

reflect: fix isRegularMemory at case Array

Browse Source 
To match cmd/compile/internal/compare.IsRegularMemory,
this CL adds code for empty arrays of comparable element type.
This commit is contained in:
Jes Cok 2024-01-24 20:09:05 +08:00
parent b4e7d630bc
commit 40db7ed510
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/reflect/type.go
View File

@ -2156,7 +2156,11 @@ func isValidFieldName(fieldName string) bool {
func isRegularMemory(t Type) bool {
switch t.Kind() {
case Array:
return isRegularMemory(t.Elem())
elem := t.Elem()
if isRegularMemory(elem) {
return true
}
return elem.Comparable() && t.Len() == 0
case Int8, Int16, Int32, Int64, Int, Uint8, Uint16, Uint32, Uint64, Uint, Uintptr, Chan, Pointer, Bool, UnsafePointer:
return true
case Struct:

3
src/reflect/type_test.go
View File

@ -78,6 +78,9 @@ func TestIsRegularMemory(t *testing.T) {
}{})}, true},
{"map[int][int]", args{reflect.TypeOf(map[int]int{})}, false},
{"[4]chan int", args{reflect.TypeOf([4]chan int{})}, true},
{"[0]struct{_ S}", args{reflect.TypeOf([0]struct {
_ S
}{})}, true},
{"struct{i int; _ S}", args{reflect.TypeOf(struct {
i int
_ S