qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-14 06:40:22 -07:00
Code Releases Activity

os/exec: disable failing LookPathTest on windows/arm64

Browse Source 
For #44379.

Change-Id: I9a3cf4d511a8286117f877c2ff9dbde56fa55983
Reviewed-on: https://go-review.googlesource.com/c/go/+/293709
Reviewed-by: Cherry Zhang <cherryyz@google.com>
Trust: Russ Cox <rsc@golang.org>
This commit is contained in:
Russ Cox 2021-02-18 11:27:23 -05:00
parent b445d6ea34
commit 40765ffa95
1 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/os/exec/lp_windows_test.go
View File

@ -143,7 +143,7 @@ func (test lookPathTest) run(t *testing.T, tmpdir, printpathExe string) {
if errCmd == nil && errLP == nil { if errCmd == nil && errLP == nil {
// both succeeded // both succeeded
if should != have { if should != have {
t.Fatalf("test=%+v failed: expected to find %q, but found %q", test, should, have) t.Fatalf("test=%+v:\ncmd /c ran: %s\nlookpath found: %s", test, should, have)
} }
return return
} }
@ -316,12 +316,17 @@ func TestLookPath(t *testing.T) {
// Run all tests. // Run all tests.
for i, test := range lookPathTests { for i, test := range lookPathTests {
dir := filepath.Join(tmp, "d"+strconv.Itoa(i)) t.Run(fmt.Sprint(i), func(t *testing.T) {
err := os.Mkdir(dir, 0700) if i == 16 {
if err != nil { t.Skip("golang.org/issue/44379")
t.Fatal("Mkdir failed: ", err) }
} dir := filepath.Join(tmp, "d"+strconv.Itoa(i))
test.run(t, dir, printpathExe) err := os.Mkdir(dir, 0700)
if err != nil {
t.Fatal("Mkdir failed: ", err)
}
test.run(t, dir, printpathExe)
})
} }
} }