bug188 - sort(x)

R=ken
OCL=33123
CL=33123

src/cmd/gc/typecheck.c

@@ -86,7 +86,7 @@ reswitch:
 	case OLITERAL:
 		ok |= Erv;
 		if(n->iota && !(top & Eiota))
-			yyerror("use of iota outside of constant initializer");
+			yyerror("use of iota not in constant initializer");
 		goto ret;
 
 	case ONONAME:
@@ -101,6 +101,10 @@ reswitch:
 		ok |= Erv;
 		goto ret;
 
+	case OPACK:
+		yyerror("use of package %S not in selector", n->sym);
+		goto error;
+
 	/*
 	 * types (OIND is with exprs)
 	 */

src/cmd/gc/walk.c

@@ -230,6 +230,10 @@ walkdef(Node *n)
 				yyerror("embedded type cannot be a pointer");
 		}
 		break;
+
+	case OPACK:
+		// nothing to see here
+		break;
 	}
 
 ret:

test/fixedbugs/bug186.go

@@ -12,7 +12,7 @@ func f(x int) { }
 
 func main() {
 	f(X);
-	f(iota);	// ERROR "iota.*outside.*initializer"
+	f(iota);	// ERROR "iota.*initializer"
 	f(X);
-	f(iota);	// ERROR "iota.*outside.*initializer"
+	f(iota);	// ERROR "iota.*initializer"
 }

test/fixedbugs/bug188.go

@@ -0,0 +1,14 @@
+// errchk $G $D/$F.go
+
+// Copyright 2009 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+import "sort"
+
+func main() {
+	var x int;
+	sort(x);	// ERROR "package.*selector"
+}